Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refine Noir.js API #2732

Merged
merged 42 commits into from
Sep 21, 2023
Merged

feat: Refine Noir.js API #2732

merged 42 commits into from
Sep 21, 2023

Conversation

kevaundray
Copy link
Contributor

Description

Main additions to the API are generateWitness and serialization methods so that the backend will receive a Uint8Array

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray
add base64 decode method
ea66d2f
@kevaundray
add wip version of input validation
723028f
@kevaundray
add initial witness generation method - does not handle return values
56dc4c1
@kevaundray
add serialize method to abstract away the discrepancies with serializ…
581758f 
…ation
@kevaundray
export new methods
752535d
@kevaundray
add mocha, prettier and add type: module for node
e94f00b
@kevaundray
add compiled_examples folder for noir tests
c45fc8f
@kevaundray
do not ignore the target folders
bcbc0ce
@kevaundray
commit .json files for noir_compiled examples
6664b72
@kevaundray
add bb test backend code
8bd188c
@kevaundray
add comment to explain why we are doing type assertions
f431c72
@kevaundray
add some smoke tests
ec3cc28
@kevaundray
add bb.js test to show how it may interact with noir.js
153a72f
@kevaundray
increase timeout
98bfa9f
@kevaundray
add another instance of null function
6386400
@kevaundray
update yarn.lock
e479c9c
@kevaundray
Merge remote-tracking branch 'origin/master' into kw/more-noir-js
c7d48fd
@kevaundray
add yarn test
4cdeeae
@kevaundray
remove .only
dd6b837
@socket-security
Copy link

socket-security bot commented Sep 16, 2023 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-prettier 4.2.1...5.0.0 None +27/-1 568 kB jounqin

🚮 Removed packages: @noir-lang/[email protected], [email protected]

@kevaundray kevaundray marked this pull request as ready for review September 18, 2023 21:59
@Savio-Sou
Copy link
Collaborator

Should this be documented as a part of / after noir-lang/docs#371?

TomAFrench
TomAFrench previously approved these changes Sep 20, 2023
View reviewed changes
vezenovm
vezenovm previously approved these changes Sep 20, 2023
View reviewed changes
tooling/noir_js/src/input_validation.ts Show resolved Hide resolved
tooling/noir_js/src/serialize.ts Show resolved Hide resolved
tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved
tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved
tooling/noir_js/test/backend/barretenberg.ts Show resolved Hide resolved
tooling/noir_js/test/node/e2e.test.ts Show resolved Hide resolved
@kevaundray kevaundray dismissed stale reviews from vezenovm and TomAFrench via 7af1dc6 September 20, 2023 23:46
@kevaundray kevaundray mentioned this pull request Sep 21, 2023
Closed
@kevaundray kevaundray added this pull request to the merge queue Sep 21, 2023
Merged via the queue into master with commit e79f1ed Sep 21, 2023
17 checks passed
@kevaundray kevaundray deleted the kw/more-noir-js branch September 21, 2023 12:03
@kevaundray kevaundray mentioned this pull request Sep 21, 2023
Merged
@TomAFrench TomAFrench mentioned this pull request Oct 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

@vezenovm vezenovm Awaiting requested review from vezenovm

Assignees
No one assigned
Labels
None yet
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevaundray @Savio-Sou @TomAFrench @vezenovm